[ACCUMULO-2894] MultiTableBatchWriter.getBatchWriter has dubious loop condition

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.6.0
• Component/s: client
• Assignee: Unassigned
• Reporter: Mike Drob
• Created: 11/Jun/14 21:15
• Updated: 02/Jun/21 18:49
• Resolved: 02/Jun/21 18:47

Description

This while loop could use a variable instead of multiple break and continue labels.

    while (true) {
      long cacheResetCount = Tables.getCacheResetCount();

      // cacheResetCount could change after this point in time, but I think thats ok because just want to ensure this methods sees changes
      // made before it was called.
      
      long internalResetCount = cacheLastState.get();

      if (cacheResetCount > internalResetCount) {
        if (!cacheLastState.compareAndSet(internalResetCount, cacheResetCount)) {
          continue; // concurrent operation, lets not possibly move cacheLastState backwards in the case where a thread pauses for along time
        }

        nameToIdCache.invalidateAll();
        break;
      }

      break;
    }