Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-2805

Exclude unused HTTP Components from thrift dependency

    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.5.0, 1.5.1, 1.6.0
    • 1.5.2, 1.6.1, 1.7.0
    • build
    • None

    Description

      libthrift pulls in the http components library for the THttpClient. AFAICT, we don't use this part of thrift.

      In 1.6+, we do use an annotation from http components within our plugin, but that module declares a direct dependency.

      When we go to handle our packaging we include libthrift but we purposefully don't include the transitive httpcomponents libraries.

      We should exclude the httpcomponents dependencies from our declaration of libthrift to preemptively avoid problems that would occur if some module (other than the maven plugin) starts making use of httpcomponents without declaring it.

      Attachments

        Issue Links

          Activity

            People

              busbey Sean Busbey
              busbey Sean Busbey
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: