[ACCUMULO-2759] Suspicious extra work in MasterMetadataUtil.fixSplit()

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 1.6.0
• Component/s: master
• Assignee: Unassigned
• Reporter: Bill Havanki
• Created: 29/Apr/14 19:23
• Updated: 31/Oct/20 11:40
• Resolved: 31/Oct/20 11:40

Description

PMD reports that four parameters are not used in the private MasterMetadataUtil.fixSplit() method: tserver, initCompactID, time, initFlushID. The public fixSplit() method, which calls the private one, does work to retrieve the latter three from a map parameter and check and tweak them, before passing them to the private method uselessly. In addition, the tserver argument is just passed from the public method to the private one untouched.

These extraneous parameters may simply be artifacts from the initial development of this code, in which case they should be cleaned up so that performance improves. It's also possible that the data should be used in the code but erroneously isn't. There's no unit test laying out its expected behavior.

(The class in question is not present before 1.6.0, but the code may be somewhere else in prior versions. That should be checked too.)