[ACCUMULO-2167] remove deprecation from ZooKeeperInstance(String, String) constructor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Assignee: Keith Turner
• Reporter: Keith Turner
• Created: 09/Jan/14 23:51
• Updated: 13/Jan/14 20:23
• Resolved: 13/Jan/14 20:19

Description

In 1.6.0-SNAPSHOT the ZooKeeperInstance(String, String) constructor was deprecated. It does not seem there is a compelling reason to do this. Below are some reasons I can think of not to do it.

• In 1.6.0 you still need to know an instance name and zookeepers to create a ZookeeperInstance programmatically. So its not like its reason for being is no longer valid.
• Its a nice conveince method for new code written against accumulo (its shorter than new ClientConfiguration()..withInstance(instanceName).withZkHosts(zooKeepers)
• Most existing code using the API probably uses it. Why annoy users unnecessarily?
• There is no maintenance burden for keeping the method

I think all of the other constructors that were deprecated should stay deprecated. Its likely those constructors are not used, and if their functionality is needed then ClientConfiguration can be used.