[ACCUMULO-2131] while statement used as if statement

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: tserver
• Labels: newbie
• Assignee: Bob Thorman
• Reporter: Eric C. Newton
• Created: 03/Jan/14 21:01
• Updated: 09/Apr/15 22:57
• Resolved: 09/Apr/15 21:33

Description

Going through PMD output, and this looks a little sketchy in SourceSwitchingIterator.java:

  private boolean switchSource() throws IOException {
    while (!source.isCurrent()) {
      source = source.getNewDataSource();
      iter = source.iterator();
      if (iflag != null)
        ((InterruptibleIterator) iter).setInterruptFlag(iflag);
      
      return true;
    }
    
    return false;
  }

I'm wondering if that "while" should be "if"