[ACCUMULO-1984] Clean up Instance closing

• Type: Improvement
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.4.5, 1.5.1, 1.6.0
• Assignee: Bill Havanki
• Reporter: Sean Busbey
• Created: 07/Dec/13 20:14
• Updated: 06/Jan/14 22:43
• Resolved: 12/Dec/13 16:27

Description

Per discussion with ctubbsii on ACCUMULO-1889:

It seems to me that the best fix is to:

• patch org.apache.accumulo.fate.zookeeper.ZooReader.close() to handle the ZooKeeper close()'s InterruptedException properly with Thread.currentThread().interrupt()
• stop propagating InterruptedException through the hierarchy of close() statements
• drop the AccumuloException from the Instance.close() method signature and make Interface extend java.io.Closeable instead (at the very least, drop the unnecessary AccumuloException and make it AutoCloseable when we switch to JDK1.7; changing it to java.io.Closeable now would ease that)
• change that catch statement to catch RuntimeExceptions instead of InterruptedException and rethrow them after fixing the counter

Since this API is just being added, we should fix these things now before it gets published in a release.

Issue Links

• breaks: ACCUMULO-2010 Remove resource leak warnings
• links to: Review