XML-RPC

Enabling the ability for the xml-rpc client to redirect requests

Created: 26/Jan/07 09:57 PM   Updated: 28/Nov/08 08:53 PM
Return to search
Component/s: Source
Affects Version/s: 3.0, 3.1
Fix Version/s: 3.1

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works redirects.patch 2007-02-11 08:48 PM Jochen Wiedmann 3 kB
Text File XMLRPC-132-patch 2007-01-27 12:47 AM Andrew Norman 13 kB
Zip Archive XMLRPC-132.zip 2007-01-27 12:47 AM Andrew Norman 6 kB

Resolution Date: 12/Apr/07 06:17 AM


 Description  « Hide
This modification to the XMLRPCStreamTransport adds a customization point to determine if the transport needs to redirect the request before attempting to parse the response from the server. This uses a similar redirect algorithm as used in the Apache Http client to processing redirects with a Max limit to prevent a recursive loop.

The redirect logic itself is implemented in two callback methods isRedirectRequired() and
resetClientForRedirect()

These callback methods are only implemented in the XmlRpcCommonsTransport which means that the other transport options won't support redirects (unless they are modified to do this by implementing these call back methods)

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Andrew Norman added a comment - 27/Jan/07 12:47 AM
this is the proposed enhancement java files, made against the 3.0 code release and synchornized against the latest code in subversion

Andrew Norman added a comment - 27/Jan/07 12:47 AM
an eclipse patch file of the proposed feature

Andrew Norman added a comment - 29/Jan/07 06:35 PM
see submitted code

Andrew Norman added a comment - 01/Feb/07 06:22 PM
this nweeds to be reviewed and commited

Jochen Wiedmann added a comment - 11/Feb/07 08:48 PM
Sorry for the delay, but I am really doing my best to manage my backlog.

Please verify the attached patch, which is based on yours, but drastically minimizes the impact.

Andrew Norman added a comment - 12/Apr/07 02:20 AM
Jochen,

sorry for the delay, but I've tested your version of the patch an it works with flying colors! Lets get this committed!

thanks for your time on this

-Andrew

Jochen Wiedmann added a comment - 12/Apr/07 06:17 AM
It's already in the trunk.

Jochen Wiedmann added a comment - 28/Nov/08 08:53 PM
Closing issues which have been released.