Bug 57164 - [PATCH] XSSFDrawing.createCellComment() does not honor dx and dy values passed in
Summary: [PATCH] XSSFDrawing.createCellComment() does not honor dx and dy values passe...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: 3.11-dev
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2014-10-29 12:14 UTC by toni97
Modified: 2014-11-16 14:54 UTC (History)
1 user (show)


Attachments
suggested patch (716 bytes, application/x-gzip)
2014-10-29 12:14 UTC, toni97 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description toni97 2014-10-29 12:14:36 UTC 
Created attachment 32164 [details]
suggested patch

XSSFDrawing.createCellComment() takes a ClientAnchor as an argument to control positioning of the created comment. While it positions the comment at the given cells it completely ignores any dx and dy values defined in the anchor and sets those to 0 on the resulting VML-drawing.

See my attached patch for how I think it should work.
Comment 1 Andreas Beeker 2014-11-16 14:54:20 UTC 
Thank you for the patch.
Applied with r1639996
I've changed that patch, so that the dx/dy values are specified as EMUs (opposed to pixels) to be in line with other client anchor usages in XSSF.
I've moved the client anchor tests for xssf/hssf to the common base class.