Bug 54111 - Extracting text from table cells inside ppt stopped working
Summary: Extracting text from table cells inside ppt stopped working
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: unspecified
Hardware: Other All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 03:39 UTC by Alex Nikiforov
Modified: 2012-11-07 16:03 UTC (History)
0 users


Attachments
JUnit test for ppt tables and fix for TextShape class (5.33 KB, text/plain)
2012-11-07 03:39 UTC, Alex Nikiforov 		Details
table_test.ppt - one slide presentation with one test table (114.50 KB, application/octet-stream)
2012-11-07 03:41 UTC, Alex Nikiforov 		Details
JUnit test for ppt tables and fix for TextShape class (5.33 KB, patch)
2012-11-07 03:44 UTC, Alex Nikiforov 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Nikiforov 2012-11-07 03:39:59 UTC 
Created attachment 29562 [details]
JUnit test for ppt tables and fix for TextShape class

By some reason TableCell#getTextRun() returns null instead of real text. I created table_test.ppt, TestTable.java class, and a quick fix for TextShape.java class. All existed JUnit tests are ok. Please review my tests and fix and apply it if possible.
Comment 1 Alex Nikiforov 2012-11-07 03:41:38 UTC 
Created attachment 29563 [details]
table_test.ppt - one slide presentation with one test table
Comment 2 Alex Nikiforov 2012-11-07 03:44:38 UTC 
Created attachment 29564 [details]
JUnit test for ppt tables and fix for TextShape class
Comment 3 Yegor Kozlov 2012-11-07 16:03:58 UTC 
Patch applied in r1406688

Thanks,
Yegor