DataSourceFactory does not support commitOnReturn property. DataSourceFactory.ALL_PROPERTIES and DataSourceFactory.parsePoolProperties() omit commitOnReturn property.
Created attachment 28897 [details] Patch for the fix. Attaching the patch for the fix to support commitOnReturn in DataSourceFactory.
Comment on attachment 28897 [details] Patch for the fix. You patch includes a lot of formatting changes. This is a no-go. Please include only changes relevant to your fix. Those seem to be - PROP_ALTERNATE_USERNAME_ALLOWED + PROP_ALTERNATE_USERNAME_ALLOWED, + PROP_COMMIT_ON_RETURN and + value = properties.getProperty(PROP_COMMIT_ON_RETURN); + if (value != null) { + poolProperties.setCommitOnReturn(Boolean.parseBoolean(value)); + } +
Created attachment 28898 [details] Cleaned up Patch for the fix Cleaned up the formatting changes. Including only the relevant changes.
Fixed by r1348056 and will be in 7.0.28