Bug 51566 - [PATCH] treat invalid picture types as loop terminator for Pictures stream
Summary: [PATCH] treat invalid picture types as loop terminator for Pictures stream
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: 3.8-dev
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-27 17:18 UTC by Gary King
Modified: 2011-10-15 14:43 UTC (History)
0 users


Attachments
git format-patch at git-svn-id 1150673 (1.20 KB, application/octet-stream)
2011-07-27 17:18 UTC, Gary King 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gary King 2011-07-27 17:18:57 UTC 
Created attachment 27325 [details]
git format-patch at git-svn-id 1150673

[MS-ODRAW] states that parsing BStoreDelay streams should be terminated when a record is read with a type that is not either 0xf007 or between 0xf018 and 0xf117.

POI was not detecting this, and frequently would throw an exception due to a negative picture length when these non-records were encountered.
Comment 1 Nick Burch 2011-10-15 14:43:18 UTC 
Thanks, applied in r1183654.