Created attachment 24512 [details] AFP output (RGB color space used for the uncalibrated CMYK) When using uncalibrated CMYK colors in FO file without a declarations tag (no need to provide the declaration tag for the uncalibrated CMYK colors, as the color profile source is not a necessary) like.... <fo:block color="rgb-icc(0, 255, 0, #CMYK, 1, 0, 1, 0)">GREEN TEXT</fo:block> <fo:block color="rgb-icc(0, 255, 255, #CMYK, 1, 0, 0, 0)">CYAN TEXT</fo:block> When trying to generate a AFP output, and the AFP renderer is using RGB color space instead of CMYK color space.. When declarations tag is used, it is generating AFP output with CMYK color space. Please find the input file and output attached to this bug.
Created attachment 24513 [details] cmyk-test input fo document
- my trunk output just contains CMYK and no RGB - could you please provide me your binary afp output file for futher analysis $ grep -A2 Color cmyk-test.dmp 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) -- 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) -- 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) -- 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) -- 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK)
Sorry, it was my mistake attached the wrong input file. Please find the newly attached input file for the bug. (In reply to comment #2) > - my trunk output just contains CMYK and no RGB > - could you please provide me your binary afp output file for futher analysis > $ grep -A2 Color cmyk-test.dmp > 0x81: SEC Set Extended Color [14] > Reserved: 00 > ColSpace: 0x04 (CMYK) > -- > 0x81: SEC Set Extended Color [14] > Reserved: 00 > ColSpace: 0x04 (CMYK) > -- > 0x81: SEC Set Extended Color [14] > Reserved: 00 > ColSpace: 0x04 (CMYK) > -- > 0x81: SEC Set Extended Color [14] > Reserved: 00 > ColSpace: 0x04 (CMYK) > -- > 0x81: SEC Set Extended Color [14] > Reserved: 00 > ColSpace: 0x04 (CMYK)
Created attachment 24521 [details] Correct Input file, please ignore the previous one
Created attachment 24523 [details] CMYK Declarations patch This patch resolves the bug, where no declarations tag is necessary for the uncalibrated CMYK.
Hi Vincent, please can you process this patch? Thanks, Chris
Created attachment 24526 [details] patch for PtocaBuilder.java The patch CMYKDeclarations.patch.txt is looking good for me but there is additional problem inside PtocaBuilder.setExtendedTextColor(). A CMYK component with value 1.0 becomes to 256 witch does not fit into one byte. Finally 0x00 is written out at the moment, but 0xff is expected.
Created attachment 24527 [details] before/after CMYKDeclarations.001.patch.txt - text 'CYAN TEXT' is written out as white color '00 00 00 00' and not visible in any afp viewer - input: <fo:block color="rgb-icc(0, 255, 255, #CMYK, 1, 0, 0, 0)">CYAN TEXT</fo:block> - output with CMYKDeclarations.patch.txt but wrong color due to interger overflow 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) Reserved: 00 00 00 00 Size1: 0x08 (8) Size2: 0x08 (8) Size3: 0x08 (8) Size4: 0x08 (8) ColValue: 00 00 00 00 0xF1: SCFL Set Coded Font Local [1] CFLid: 0x01 (1) 0xC5: SVI Set Variable-Space Char Increment [2] Value: 0x000B (11) 0xDB: TRN Transparent Data [9] Text: "CYAN TEXT" - output with CMYKDeclarations.patch.txt and CMYKDeclarations.001.patch.txt 0x81: SEC Set Extended Color [14] Reserved: 00 ColSpace: 0x04 (CMYK) Reserved: 00 00 00 00 Size1: 0x08 (8) Size2: 0x08 (8) Size3: 0x08 (8) Size4: 0x08 (8) ColValue: FF 00 00 00 0xF1: SCFL Set Coded Font Local [1] CFLid: 0x01 (1) 0xC5: SVI Set Variable-Space Char Increment [2] Value: 0x000B (11) 0xDB: TRN Transparent Data [9] Text: "CYAN TEXT"
Hi Harald G. Henne, You are right, I have prepared two different patches( this bug relates to fo:declarations tag is not neccessary for uncalibrated CMYK colors, and the other patch for the bug 48185 will fix the problem you mentioned). Please check the other bug for the details... https://issues.apache.org/bugzilla/show_bug.cgi?id=48185 I have enabled the dependency attribute between these two bugs...
Patch applied in rev. 883310: http://svn.apache.org/viewvc?rev=883310&view=rev Thanks! Vincent
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed