Bug 48048 - [PATCH] AFP renderer outputs incorrect values for GBAR ( Graphics Begin Area )
Summary: [PATCH] AFP renderer outputs incorrect values for GBAR ( Graphics Begin Area )
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: all
Hardware: All Linux
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-24 11:18 UTC by d.w. harks
Modified: 2012-04-01 06:56 UTC (History)
0 users



Attachments
Patch (1014 bytes, patch)
2009-10-24 11:18 UTC, d.w. harks
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description d.w. harks 2009-10-24 11:18:10 UTC
Created attachment 24414 [details]
Patch

Per the AFP GOCA specification at
http://www.outputlinks.com/SpecialInterest/AFPColorConsortium/ibm_goca_ha3n1r01.pdf
, the GBAR order should output two bytes: 0x68 (the order code) and a 1-byte
set of bit flags.

The current FOP implementation interprets the specification in a
least-significant-bit fashion: bit 0 is the least-valued bit, and bit 1 is the
next-least-valued bit to the left. This makes the valid values (in hex) either
0x01 or 0x03, and the constants are set to generate these values.

However, according to the preface to the specification (page iv, or #6 in the
PDF) , "bits are specified with bit 0 meaning the most significant bit".

Interpreting the specification this way makes the valid values for the second
byte either 0x80 or 0xC0.

The attached patch updates the Graphics Begin Area code to use the proper
constant values.

Many AFP viewers and printers ignore the bit field entirely, but those that
interpret it strictly reject FOP's generated AFP output.

To reproduce: Render an FO containing an SVG into AFP format; then examine the
output using an AFP interpreter or hex editor.
Comment 1 Jeremias Maerki 2009-11-25 07:05:24 UTC
Thanks for spotting this and sending a patch! It is applied now: http://svn.apache.org/viewvc?rev=884129&view=rev
Comment 2 Glenn Adams 2012-04-01 06:56:28 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed