When I build tomcat 6.0 trunk on my Chinese version Windows XP OS, I got an encoding error. So I'd like add <compilerarg line="-encoding UTF-8 "/> into all the <javac></javac> nodes in build.xml and dist.xml. Since I could only upload one file each time, I only upload revised version of build.xml. This is my first time to issue a bugzilla entry, sorry for the non-standard format.
Created attachment 23606 [details] This is revised version of build.xml This is revised version of build.xml
You should not change 'Assigned To' field of a bug. Because of that the bug update notifications aren't coming to the dev@ mailing list. I am resetting it to the default value.
Fixed in trunk and proposed for 6.0.x
Ignore my last comment. This isn't fixed in trunk yet.
Created attachment 23765 [details] Proposed patch using ISO-8859-1 The source files aren't UTF-8 encoded. They are ISO-8859-1. Whilst I can get a Chinese copy of XP, I doubt I;d be able to use it. Could you test the attached patch and see if it works for you? If it does, I'll modify the other build scripts in the same way, apply the patch to trunk and propose it for 6.0.x
One correction: There is an easier way: use encoding="ISO-8859-1" attribute on the javac task. I see no need for the explicit <compilerarg>.
The patch proposed by Konstantin Kolinko works fine for me. I think we could close this issue.
Just add encoding="ISO-8859-1" at the end of all javac element.
Fixed in trunk, proposed for 6.0, 5.5.
Fixed in 5.5, 6.0. Will be in 5.5.28, 6.0.21 onwards.