Bug 46288 - Red crosses (X) instead of images in created Slideshows
Summary: Red crosses (X) instead of images in created Slideshows
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: 3.8-dev
Hardware: PC Windows Vista
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 03:14 UTC by Daniel
Modified: 2011-12-09 12:51 UTC (History)
0 users



Attachments
Patch to correct the refcount handling for Fill pictures (5.35 KB, patch)
2011-12-08 21:11 UTC, Jim Talbut
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel 2008-11-25 03:14:33 UTC
I create a slideshow the usual way.
The only objects i insert, are images.

The way i do this is the following:

slide = slideShow.createSlide();
			slide.setFollowMasterBackground(false);
			
			Fill fill = slide.getBackground().getFill();
			int pictureData = slideShow.addPicture(outputFile, Picture.PNG);
			fill.setFillType(Fill.FILL_PICTURE);
			fill.setPictureData(pictureData);

I guess its easy to understand.
after creating my slideshow, i open it in powerpoint and the first things i see are red X's or Crosses.

The Symbol for a image that can not be shown.
A workaround to see the images is so save the Slideshow againg and switch the viewing mode.

am i doing something wrong?
are there known issues?
i would like to see my images correct.

Regards,
DAniel
Comment 1 Jim Talbut 2011-12-08 21:05:41 UTC
The problem is that the refcount on the EscherBSERecord is not maintained correctly for fills (although it is for Pictures).
I'll upload a patch as soon as I've got the tests working.
Comment 2 Jim Talbut 2011-12-08 21:11:50 UTC
Created attachment 28056 [details]
Patch to correct the refcount handling for Fill pictures
Comment 3 Yegor Kozlov 2011-12-09 12:51:39 UTC
Applied in r1212381

Thanks,
Yegor