Bug 45414 - Exception on setForceFormulaRecalculation with diagram in sheet
Summary: Exception on setForceFormulaRecalculation with diagram in sheet
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-17 00:22 UTC by Renier Roth
Modified: 2008-07-18 11:36 UTC (History)
0 users


Attachments
patch to fix above bug (1.48 KB, patch)
2008-07-17 00:22 UTC, Renier Roth 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renier Roth 2008-07-17 00:22:50 UTC 
Created attachment 22268 [details]
patch to fix above bug

Attached is a patch to fix a bug occured, if '_isUncalced' (setForceFormulaRecalculation) flag is set and the sheet contain a diagram in POI Version 3.1 Final.

The exception thrown is 'IllegalStateException' with different sizes for serialized and pre-calculated size. If a diagramm is inside a sheet it generates another 'BOFRecord' as seen in Sheet line 829. This serialize more then one 'UncalcedRecord' records, pre-calculation count only one.

The patch extend the if statement to output the 'UncalcedRecord' only once.
Comment 1 Nick Burch 2008-07-18 11:36:25 UTC 
Thanks for this patch. I've committed it to svn, along with a unit test to verify that everything's working properly (and stays working properly!)