Bug 44345 - [patch] Added implementations for Excel functions COUNTA, COUNTIF, INDEX, ROWS, COLUMNS
Summary: [patch] Added implementations for Excel functions COUNTA, COUNTIF, INDEX, ROW...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: 3.0-dev
Hardware: Other other
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-01 16:26 UTC by Josh Micich
Modified: 2008-02-04 02:49 UTC (History)
0 users



Attachments
svndiff and added files (7.83 KB, application/octet-stream)
2008-02-01 16:31 UTC, Josh Micich
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Micich 2008-02-01 16:26:31 UTC
Stub implementations of (COUNTA, COUNTIF, INDEX, ROWS, COLUMNS ) were filled 
in.  Some specific case of these functions are still not implemented, but 
basic behaviour is there.
Added test cases for these and some other functions.

Note also - there is an unrelated change in HyperlinkRecord.java
The current version appears to be using a JDK5 API. 
(IllegalStateException.<init>(Throwable) ). Please correct me if JDK5 is ok to 
use.
Comment 1 Josh Micich 2008-02-01 16:31:41 UTC
Created attachment 21460 [details]
svndiff and added files
Comment 2 Yegor Kozlov 2008-02-03 11:17:47 UTC
The attached archive contains only unit tests. The implementation is missing. 

Regards,
Yegor
Comment 3 Nick Burch 2008-02-04 02:49:25 UTC
Thanks for the patch (spotted it hidden in the tar file!) and unit tests

I've applied them to svn trunk.

As for the JDK issue, we are aiming for it to still build on jdk 1.4, but
sometimes a 1.5 jdk will happily compile some 1.5 only stuff when in 1.4
compatibility mode, so the odd things slips through :(