Bug 43605 - [PATCH] No page-number-citation in FOEventHandler
Summary: [PATCH] No page-number-citation in FOEventHandler
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: fo tree (show other bugs)
Version: 0.94
Hardware: Other All
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks: 43606
  Show dependency tree
 
Reported: 2007-10-11 14:14 UTC by V Schappert
Modified: 2012-04-01 07:10 UTC (History)
0 users


Attachments
Adds support for page-number-citation etc. to FOEventHandler... (2.97 KB, patch)
2007-10-11 16:52 UTC, V Schappert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description V Schappert 2007-10-11 14:14:24 UTC 
There is no support for page-number-citation and page-number-citation-last in
FOEventHandler.  This is because of the following relatively simple omissions:

(1) org.apache.fop.fo.FOEventHandler :
       o   needs empty method startPageNumberCitation(PageNumberCitation)
       o   needs empty method endPageNumberCitation(PageNumberCitation)
       o   needs empty method startPageNumberCitationLast(PageNumberCitationLast)
       o   needs empty method endPageNumberCitationLast(PageNumberCitationLast)
(2) org.apache.fop.fo.flow.PageNumberCitation:
       o   method startOfNode() needs to call
getFOEventHandler().startPageNumberCitation(this);
       o   method endOfNode() needs to call
getFOEventHandler().endPageNumberCitation(this);
(3) org.apache.fop.fo.flow.PageNumberCitationLast:
       o   method startOfNode() needs to call
getFOEventHandler().startPageNumberCitationLast(this);
       o   method endOfNode() needs to call
getFOEventHandler().endPageNumberCitationLast(this);

The fixes are trivial (simply add about 15 missing lines as directed above).
Comment 1 V Schappert 2007-10-11 16:52:57 UTC 
Created attachment 20966 [details]
Adds support for page-number-citation etc. to FOEventHandler...

This patch should completely resolve the bug -- it is relatively
straightforward.
Comment 2 Jeremias Maerki 2007-11-18 08:58:18 UTC 
Patch applied to FOP Trunk, thanks:
http://svn.apache.org/viewvc?rev=596097&view=rev

However, I had to modify the patch since it had a bug. See the commit message
for details.
Comment 3 Glenn Adams 2012-04-01 07:10:06 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed