Bug 43070 - [PATCH] Postscript extension : comment before and after page
Summary: [PATCH] Postscript extension : comment before and after page
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: ps (show other bugs)
Version: trunk
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on: 42144
Blocks:
  Show dependency tree
 
Reported: 2007-08-09 04:16 UTC by Adrian Cumiskey
Modified: 2012-04-01 07:01 UTC (History)
0 users



Attachments
patch file (24.11 KB, patch)
2007-08-09 09:03 UTC, Adrian Cumiskey
Details | Diff
patch file (26.39 KB, patch)
2007-08-10 02:21 UTC, Adrian Cumiskey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Cumiskey 2007-08-09 04:16:41 UTC
see http://wiki.apache.org/xmlgraphics-fop/ExtensionsForPostScript for full
details of <ps:ps-comment-before/> and <ps:ps-comment-after/>.

The requirement for the comment-before and comment-after is for post-processing
the postscript output. Both these elements may only be declared as child nodes
of fo:declarations and/or fo:simple-page-master.

In a fo:declarations context, ps-comment-before is placed in the postscript
output just before the %%EndComments DSC comment in the header and
ps-comment-after is placed just after the %%Trailer DSC comment in the footer of
the output.

In a fo:simple-page-master context, ps-comment-before is placed in the
postscript output just after the %%BeginPageSetup DSC comment and a
ps-comment-after just after the %%PageTrailer DSC comment in each page of a
simple page master referring page sequence.

Patch (with dependency on
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144 being applied) to follow.
Comment 1 Adrian Cumiskey 2007-08-09 09:03:31 UTC
Created attachment 20625 [details]
patch file

Again, please note this patch depends upon
http://issues.apache.org/bugzilla/show_bug.cgi?id=42144 being applied first.

Adrian.
Comment 2 Adrian Cumiskey 2007-08-10 02:21:19 UTC
Created attachment 20635 [details]
patch file

This patch file superceeds the last one.  It fixes a bug that I introduced on
PSRenderer.java in the patch file I provided yesterday.

Adrian.
Comment 3 Chris Bowditch 2007-10-05 01:40:57 UTC
Patch Applied with one minor modification. The Abstract class 
AbstractPSComment extended PSExtensionAttachment but didn't appear to be 
adding any value. PSCommentAfter and PSCommentBefore both extended it but the 
Abstract class had nothing more than the constructors. There is no code that 
works with the Abstract class either, so it made sense to change 
PSCommentAfter & PSCommentBefore to extend PSExtensionAttachment directly.

I then tested the patch using my local PS Printer (and Text Editor) and it 
works great. Thanks Adrian!
Comment 4 Glenn Adams 2012-04-01 07:01:43 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed