Bug 39907 - Dynamic (balancer-manager induced) changes revert to configured defaults
Summary: Dynamic (balancer-manager induced) changes revert to configured defaults
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_proxy_balancer (show other bugs)
Version: 2.2.4
Hardware: Other Linux
: P1 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-27 09:03 UTC by Andrew Stribblehill
Modified: 2007-09-25 06:54 UTC (History)
0 users



Attachments
mod_proxy_balancer patch (1.29 KB, patch)
2007-09-04 13:07 UTC, Vinicius Petrucci
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Stribblehill 2006-06-27 09:03:29 UTC
Using MPM: Worker

To reproduce:
 1: make a change to LoadFactor on a balancer member, within the
balancer-manager system
 2: send a bunch of requests to the load balancer
 3: reload the balancer-manager page.

It sometimes reverts to the configured default load factors.

Conjecture: this might be when the balancer-manager is invoked from a different
process from the one in which the original change was made. This is supported by
the fact that just a few sporadic requests don't revert the changes, but
high-concurrency testing seems to revert them.

I haven't tested the impact of changing other parameters within balancer-manager.
Comment 1 Jim Jagielski 2006-10-19 08:12:29 UTC
Thank you for the bug report. I will look into it, but it sounds as though the manager is updating only its 
local copy of the info.
Comment 2 Vinicius Petrucci 2007-09-02 14:44:28 UTC
I commented out the section of code below the comentary "/* Set to the original
configuration */" at "init_balancer_members" on mod_proxy_balancer.c

But It seems not be a nice solution...
Comment 3 Vinicius Petrucci 2007-09-02 15:09:33 UTC
(In reply to comment #2)
> I commented out the section of code below the comentary "/* Set to the original
> configuration */" at "init_balancer_members" on mod_proxy_balancer.c
> 
> But It seems not be a nice solution...

This patch prevents mod_proxy_balancer from overwriting the status of workers
when creating a new child process
(http://svn.apache.org/viewcvs?rev=374929&view=rev). Maybe there's some
directions there...
Comment 4 Vinicius Petrucci 2007-09-04 13:07:52 UTC
Created attachment 20770 [details]
mod_proxy_balancer patch
Comment 5 Vinicius Petrucci 2007-09-04 13:09:30 UTC
Comment on attachment 20770 [details]
mod_proxy_balancer patch

This patch prevents mod_proxy_balancer from overwriting the lbfactor, lbset,
and lbstatus of workers when creating a new child process.
Comment 6 Ruediger Pluem 2007-09-25 06:54:41 UTC
Fixed in trunk as r574485
(http://svn.apache.org/viewvc?view=rev&revision=574485), backported to 2.2.x as
r575708 (http://svn.apache.org/viewvc?view=rev&revision=575708)