The MSBuild task (DotNet 1.6.2 compatible) fails to properly delimit targets and properties when multiple targets or properties are specified. Example <msbuild> <property name="Prop1" value="abc"/> <property name="Prop2" value="xyz"/> </msbuild> results in -p:Prop1=abcProp2=xyz. Note the missing semicolon between the Prop1 and Prop2 name-value pairs. Patch follows: Index: MSBuildTask.java =================================================================== --- MSBuildTask.java (revision 372335) +++ MSBuildTask.java (working copy) @@ -64,6 +64,9 @@ if (!first) { sb.append(";"); } + else { + first = false; + } sb.append(t.getName()); } return new String[]{sb.toString()}; @@ -83,6 +86,9 @@ if (!first) { sb.append(";"); } + else { + first=false; + } sb.append(p.getName()).append("=").append(p.getValue()); } return new String[]{sb.toString()}; ~
Created attachment 17504 [details] Proposed patch - fixes the delimiter problem This is the first time I've ever submitted a bug/patch so I'm sorry if I didn't adhere to the correct process.
I've just created new components for the three new antlibs. Will take care of the bug.
fixed in svn: http://svn.apache.org/viewcvs?rev=372448&view=rev http://svn.apache.org/viewcvs?rev=372450&view=rev