Bug 37557 - missleading error msg from-table-column
Summary: missleading error msg from-table-column
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: page-master/layout (show other bugs)
Version: trunk
Hardware: Other All
: P4 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-18 15:15 UTC by gerhard oettl
Modified: 2012-04-01 07:08 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gerhard oettl 2005-11-18 15:15:31 UTC
i would suggest, that always the "unimplemented" error is thrown, because the
the "incorrect parameter ..." error sounds like there is something wrong with
the user fo-file whats a litte bit missleading. 
A clear error-message would prevent others from searching the error on their
side and finding after all (after looking to the source) that it is an
unimplementet feature.
May be additionally a comment on the table-cell entry of the compliance-page
would be helpfull.
Comment 1 Chris Bowditch 2005-11-18 15:55:22 UTC
Sorry your bug report isn't clear. What messages are you referring to?

Please provide a sample FO file that demonstrates the problem (attach it to 
the bug report, don't Copy & Paste it in) together with a more precise 
description of the error messages you are referring to. Thanks,

Chris
Comment 2 gerhard oettl 2005-11-18 19:30:30 UTC
in /src/java/org/apache/fop/fo/expr/FromTableColumnFunction.java
all the "public Property eval" does is to decide between two 
PropertyExeceptions.

case 1) the construct:
<fo:table ...
<fo:cell>
<fo:block text-align="from-table-colum(text-align)">
... </fo:table>

results in:
"from-table-column unimplemented!"


case 2) but the following more common construct 
(valid according to
http://www.w3.org/TR/xsl/slice5.html#section-N7097-Function-Calls)

<fo:table ...
<fo:cell>
<fo:block text-align="from-table-colum()">
... </fo:table>

results in:
"Incorrect parameter to from-table-column function"

that may be correct for the internal work of fop, but looks (at least for me)
like there was something wrong with the statment in my fo-file.

because the "fo:from-table-column()" is not implemented at all
(as far as i can see the FromTableColumnFunction.java does not more than
decide between this two messages) i think it would be clearer for the end-user
to see only the first message in all cases (for now). The second message leads
to the thinking that there is an error in the fo-file ("fo:from-table-column()")
and what was missleading for me.

you see: complaining about obscurity i am not precise myself ;-)

gerhard



Comment 3 Jeremias Maerki 2005-11-24 16:13:09 UTC
I fixed it in SVN Trunk:
http://svn.apache.org/viewcvs?rev=348749&view=rev

Thanks for reporting the problem.
Comment 4 Glenn Adams 2012-04-01 07:08:09 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed