Bug 36379 - [PATCH] Revised percentage resolution system
Summary: [PATCH] Revised percentage resolution system
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: page-master/layout (show other bugs)
Version: trunk
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-26 15:15 UTC by Manuel Mall
Modified: 2012-04-01 06:49 UTC (History)
0 users



Attachments
The main patch (211.89 KB, patch)
2005-08-26 15:16 UTC, Manuel Mall
Details | Diff
One new class to go into org.apache.fop.layoutmgr (7.01 KB, text/plain)
2005-08-26 15:17 UTC, Manuel Mall
Details
Another new class for org.apache.fop.datatypes (1.30 KB, text/plain)
2005-08-26 15:18 UTC, Manuel Mall
Details
A few additional testcases (3.35 KB, application/java-archive)
2005-08-26 15:19 UTC, Manuel Mall
Details
Revised patch (301.41 KB, patch)
2005-08-30 14:02 UTC, Manuel Mall
Details | Diff
New class to go into org.apache.fop.layoutmgr (7.62 KB, text/plain)
2005-08-30 14:03 UTC, Manuel Mall
Details
New class for org.apache.fop.datatypes (1.42 KB, text/plain)
2005-08-30 14:04 UTC, Manuel Mall
Details
Another new class for org.apache.fop.datatypes (1.73 KB, text/plain)
2005-08-30 14:05 UTC, Manuel Mall
Details
Testcases (19.24 KB, application/x-zip-compressed)
2005-08-30 14:05 UTC, Manuel Mall
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Mall 2005-08-26 15:15:22 UTC
Wow, this is the big one (from my perspective any way).

See http://marc.theaimsgroup.com/?t=112437927400002&r=1&w=2 for some background
info.

This patch affects a lot of classes (most in a minor way) especially in the LM
section. It passes all layout engine tests and I have compared the area trees
with the current trunk code. I therefore sincerely hope it is not a step backwards.

There are also some steps forward. Percentages on leader-length and
leader-pattrern-width should work. background-position-x/y percentages should
also work in a generic way. Percentages relative to cell dimensions should be ok.

There is more work to be done in this area. This is not the final word on
percentages. But because of its size I would like to get this reviewed and if
accepted put into SVN so my code base doesn't branch too badly from the main stream.

BTW, I haven't got rid completely of the LayoutDimension stuff. It is still used
for tables columns with proportional-column-width() specs. This still needs to
be looked at.
Comment 1 Manuel Mall 2005-08-26 15:16:21 UTC
Created attachment 16213 [details]
The main patch
Comment 2 Manuel Mall 2005-08-26 15:17:20 UTC
Created attachment 16214 [details]
One new class to go into org.apache.fop.layoutmgr
Comment 3 Manuel Mall 2005-08-26 15:18:22 UTC
Created attachment 16215 [details]
Another new class for org.apache.fop.datatypes
Comment 4 Manuel Mall 2005-08-26 15:19:01 UTC
Created attachment 16216 [details]
A few additional testcases
Comment 5 Manuel Mall 2005-08-30 14:02:59 UTC
Created attachment 16248 [details]
Revised patch

Revised, extended and better tested patch
Comment 6 Manuel Mall 2005-08-30 14:03:54 UTC
Created attachment 16249 [details]
New class to go into org.apache.fop.layoutmgr
Comment 7 Manuel Mall 2005-08-30 14:04:34 UTC
Created attachment 16250 [details]
New class for org.apache.fop.datatypes
Comment 8 Manuel Mall 2005-08-30 14:05:00 UTC
Created attachment 16251 [details]
Another new class for org.apache.fop.datatypes
Comment 9 Manuel Mall 2005-08-30 14:05:38 UTC
Created attachment 16252 [details]
Testcases
Comment 10 Finn Bock 2005-08-31 22:37:43 UTC
Applied as revision 265577.

I changed the handling of line-height and font-size and "em" unit to avoid the
calculation of FixedLengths and changed the LM.initialize() so it is called once
from the parent LM just before getNextKnuthElements are about to be called.

The change to PDFRendere was not included in the commit.

Discussion of the patch here:

  http://marc.theaimsgroup.com/?t=112506553400001&r=1&w=2
Comment 11 Manuel Mall 2005-09-01 03:05:46 UTC
Finn, Thank you! 
Comment 12 Glenn Adams 2012-04-01 06:49:57 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed