Bug 35054 - warn if appBase is not existing as a File or directory
Summary: warn if appBase is not existing as a File or directory
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Catalina (show other bugs)
Version: Nightly Build
Hardware: Other All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-25 10:03 UTC by Ralf Hauser
Modified: 2011-05-20 18:11 UTC (History)
0 users



Attachments
HostConfig.java.patch (1017 bytes, patch)
2005-05-25 10:04 UTC, Ralf Hauser
Details | Diff
HostConfig.java.patch2 (1.54 KB, patch)
2005-05-25 11:30 UTC, Ralf Hauser
Details | Diff
HostConfig.java.patch3 (1.58 KB, patch)
2005-07-22 06:45 UTC, Ralf Hauser
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Hauser 2005-05-25 10:03:08 UTC
otherwise, it may very hard to find what is wrong
Comment 1 Ralf Hauser 2005-05-25 10:04:42 UTC
Created attachment 15162 [details]
HostConfig.java.patch

a little bit more user-friendly
Comment 2 Ralf Hauser 2005-05-25 11:30:45 UTC
Created attachment 15163 [details]
HostConfig.java.patch2

yet more user-friendliness (and an error less)
Comment 3 Yoav Shapira 2005-07-21 23:45:24 UTC
I don't understand: your patches actually remove logging statements, yet the
title of this issue asks to add a warning, no?
Comment 4 Ralf Hauser 2005-07-22 06:45:29 UTC
Created attachment 15742 [details]
HostConfig.java.patch3

corrected - now using

diff -u HostConfig.java.orig HostConfig.java
Comment 5 Mark Thomas 2011-05-20 18:11:32 UTC
Specifying a non-existing appBase is not necessarily invalid. By default, Tomcat 7 will create the appBase if it does not already exist.

I have tweaked the tests Tomcat does in case a file is specified as an appBase.

I do not propose back-porting this to Tomcat 5 or 6.