I used the http://findbugs.sourceforge.net/ tool to locate unused variables, dead assignments, etc. Here is a patch to clean up some things.
Created attachment 14943 [details] Misc. fixes to log4j CVS tree
Some suggested changes had already been fixed or the underlying code eliminated or substantially rewritten. Many of the changes were to variables that were not declared a private which means that eliminating them may cause binary-compatibility problems though usually only limited to code that inserted itself into a org.apache.log4j package to access package visible members. The two changes that were committed were to make NA_LOCATION_INFO final and changing the notify's in Scheduler to notifyAll and synchronizing the close method. Scheduler has been very problematic in the Gump tests, use of notify might have been at least partially responsible. I'm changing the title to reflect the major effect of the change. Committed rev 439177.