Bug 32225 - [PATCH] prefixed attibutes for fo: namespace
Summary: [PATCH] prefixed attibutes for fo: namespace
Status: CLOSED WONTFIX
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: 0.20.5
Hardware: All All
: P3 enhancement
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-13 15:32 UTC by Balint Reczey
Modified: 2012-04-01 13:49 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Balint Reczey 2004-11-13 15:32:16 UTC 
Index: xml-fop/src/org/apache/fop/fo/PropertyListBuilder.java
===================================================================
RCS file:
/home/cvspublic/xml-fop/src/org/apache/fop/fo/Attic/PropertyListBuilder.java,v
retrieving revision 1.33.2.1
diff -w -u -r1.33.2.1 PropertyListBuilder.java
--- xml-fop/src/org/apache/fop/fo/PropertyListBuilder.java      25 Feb 2003
12:56:54 -0000      1.33.2.1
+++ xml-fop/src/org/apache/fop/fo/PropertyListBuilder.java      13 Nov 2004
15:21:16 -0000
@@ -161,7 +161,16 @@
         }
 
         for (int i = 0; i < attributes.getLength(); i++) {
-            String attributeName = attributes.getQName(i);
+            
+           String attributeName;
+           // If we have a Format attribute, omit prefix
+           if (attributes.getURI(i) == "http://www.w3.org/1999/XSL/Format")
+           {
+           
+               attributeName = attributes.getLocalName(i);
+           } else {
+               attributeName = attributes.getQName(i);
+           }
             /* Handle "compound" properties, ex. space-before.minimum */
             int sepchar = attributeName.indexOf('.');
             String propName = attributeName;
Comment 1 Tor Iver Wilhelmsen 2006-12-04 03:00:18 UTC 
The patch code uses

attributes.getURI(i) == "http://www.w3.org/1999/XSL/Format"

However, it really should use .equals() shouldn't it?
Comment 2 Balint Reczey 2006-12-04 06:25:08 UTC 
Of course.
Comment 3 Jeremias Maerki 2007-02-03 14:05:30 UTC 
The development of the maintenance branch has stopped. The code in FOP
Trunk/0.93 is much more flexible and should handle the cases this patch
addresses. Closing the issue.
Comment 4 Glenn Adams 2012-04-01 13:49:43 UTC 
batch transition to closed remaining pre-FOP1.0 resolved bugs