Bug 31511 - setenv.bat missing, but required by shutdown-using-launcher
Summary: setenv.bat missing, but required by shutdown-using-launcher
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Unknown (show other bugs)
Version: 5.0.28
Hardware: Other Windows XP
: P3 minor (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-02 16:51 UTC by Sebb
Modified: 2004-11-16 19:05 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2004-10-02 16:51:17 UTC
startup-using-launcher.bat uses setenv.bat if it finds it.

However shutdown-using-launcher.bat always calls setenv.bat even if it did not
find it in the local directory, thus reports an error.

== code extract ==
rem %0 must have been found by DOS using the %PATH% so we assume that
rem setenv.bat will also be found in the %PATH%
call setenv.bat
== ends ==

The same code is to be found in tool-wrapper-using-launcher.bat

Whereas catalina.bat (and some other BAT files) use the construct:
if exist "%CATALINA_HOME%\bin\setenv.bat" call "%CATALINA_HOME%\bin\setenv.bat"

It seems to me that either setenv.bat should be provided, or it should not be
required.
Comment 1 Yoav Shapira 2004-10-05 14:23:05 UTC
setenv.bat shouldn't be provided, as it's optional.  So I agree it shouldn't be 
required.
Comment 2 Yoav Shapira 2004-10-05 14:29:28 UTC
Fixed on both the Tomcat 5.0 and 5.5 branches.  Thanks for pointing this out.