Bug 30847 - [patch] Block.java loop terminator fails due to a bug
Summary: [patch] Block.java loop terminator fails due to a bug
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: page-master/layout (show other bugs)
Version: 0.20.5
Hardware: Other other
: P1 critical
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-25 14:11 UTC by tagunov
Modified: 2012-04-01 06:29 UTC (History)
0 users


Attachments
Fix that terminates endless loop in one particular case (679 bytes, text/xml)
2004-08-25 14:12 UTC, tagunov 		Details
the same fix now with a correct mime type (679 bytes, patch)
2004-08-25 14:13 UTC, tagunov 		Details | Diff
Bang! Prev patch was buggy. THIS IS THE PATCH!!! (1.01 KB, patch)
2004-08-25 14:23 UTC, tagunov 		Details | Diff
Sample input files (30.00 KB, application/octet-stream)
2004-08-25 17:02 UTC, tagunov 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tagunov 2004-08-25 14:11:02 UTC 
#8778 was fixed with a really helpful patch, but a small bug(?) in Block.java does not fix #8778 to always work as expected. Please review this patch and apply if correct.
Comment 1 tagunov 2004-08-25 14:12:35 UTC 
Created attachment 12524 [details]
Fix that terminates endless loop in one particular case
Comment 2 tagunov 2004-08-25 14:13:29 UTC 
Created attachment 12525 [details]
the same fix now with a correct mime type
Comment 3 tagunov 2004-08-25 14:23:20 UTC 
Created attachment 12526 [details]
Bang! Prev patch was buggy. THIS IS THE PATCH!!!
Comment 4 tagunov 2004-08-25 17:02:19 UTC 
Created attachment 12528 [details]
Sample input files
Comment 5 tagunov 2004-08-25 17:04:06 UTC 
Bug #8778 is fixed.
A loop terminator has been built into Block#layout.
However it looks like line terminator fails on some input files - sample provided.
The proposed patch fixes the problem.

Please review and apply if appropriate.
Comment 6 Pascal Sancho 2007-11-20 01:43:31 UTC 
Fixed in FOP 0.94 and probably earlier versions
Comment 7 Glenn Adams 2012-04-01 06:29:37 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed