Bug 29486 - Consolidate page generation code into FOTreeHandler
Summary: Consolidate page generation code into FOTreeHandler
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: page-master/layout (show other bugs)
Version: trunk
Hardware: Other other
: P3 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-09 23:41 UTC by Glen Mazza
Modified: 2012-04-01 06:29 UTC (History)
0 users



Attachments
patch file (17.31 KB, text/plain)
2004-06-09 23:42 UTC, Glen Mazza
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Mazza 2004-06-09 23:41:53 UTC
Team,

The following patch removes the event-driven messaging between fo.FOTreeHandler 
and apps.Document (used to activate the layout of each page sequence) and 
instead consolidates the formatPageSequence() activation into 
fo.FOTreeHandler.  In effect, the business logic to start the layout process 
for each fo:page-sequence is consolidated from 5 classes (Driver, Document, 
FOTreeHandler, fo.FOTreeListener, fo.FOTreeEvent) back into one 
(fo.FOTreeHandler).

This change is nothing new--it is closely similar in functionality to the 
former LayoutMgr.LayoutHandler [1], that we maintained through August of last 
year.  (It is this class that became FOTreeHandler once this functionality was 
taken out.)

[1] http://cvs.apache.org/viewcvs.cgi/xml-
fop/src/java/org/apache/fop/layoutmgr/Attic/LayoutHandler.java?rev=1.5&view=auto

With this change, two classes will be dropped:  fo.FOTreeListener and 
fo.FOTreeEvent, two simplified (Driver and Document), and even the class 
retaining the logic (FOTreeHandler) will not be much larger, because all the 
event messaging logic has been removed from it.  Streamlining this code will 
also aid in better comprehension of the process, hopefully making the code less 
intimidating/more attractive for others to work with.

Will apply unless too much grief over the next couple of days!

Thanks,
Glen
Comment 1 Glen Mazza 2004-06-09 23:42:46 UTC
Created attachment 11807 [details]
patch file
Comment 2 Glen Mazza 2004-06-11 17:21:28 UTC
Applied.
Comment 3 Glenn Adams 2012-04-01 06:29:47 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed