Bug 28908 - Oracle.sql incorrect
Summary: Oracle.sql incorrect
Status: RESOLVED FIXED
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: Appender (show other bugs)
Version: 1.3alpha
Hardware: Other other
: P5 normal
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-05-11 18:01 UTC by James Stauffer
Modified: 2007-01-30 15:30 UTC (History)
0 users


Attachments
src/java/org/apache/log4j/db/dialect/oracle.sql update to work with Oracle 9.2 (3.27 KB, patch)
2004-05-11 18:07 UTC, James Stauffer 		Details | Diff
Updated diff with white space changes removed (3.15 KB, patch)
2004-05-12 12:26 UTC, James Stauffer 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Stauffer 2004-05-11 18:01:12 UTC 
src/java/org/apache/log4j/db/dialect/oracle.sql is incorrect.  At least with
Oracle 9.2 I had to make major changes.  I'll attach the patch.
Comment 1 James Stauffer 2004-05-11 18:07:18 UTC 
Created attachment 11514 [details]
src/java/org/apache/log4j/db/dialect/oracle.sql update to work with Oracle 9.2
Comment 2 James Stauffer 2004-05-11 18:42:16 UTC 
It appears the serverity should be normal.
Comment 3 Paul Smith 2004-05-11 22:40:14 UTC 
Diff's can be hard to read, but is this basically changing all 'int' columns to 
INTEGER(10) and BIGINTS to INTEGER(20)?

If this is the case, then I would +1 this patch, in fact, I'd recommend the use 
of Integer over int/bigint any day, mainly because of some postgres weirdness 
that burnt me to a crisp one day.

However the patch seems to have lots-o-white-space, so rather than apply the 
patch as such, should I apply your recommendation of changing the int/bigints 
to number?
Comment 4 Ceki Gulcu 2004-05-12 08:46:05 UTC 
Hello James,

Thank you for looking into this. I was expecting that some minor fixes
would be required but not changing every single line.

What is wrong with an SQL 92 type such as INTEGER? I would much prefer
to change the lines which are wrong rather than the lines which get
changed while hunting for the lines which were really wrong.

My suggestion would be to continue to dialog on log4j-dev. If you agree,
I'll close this bug report.
Comment 5 James Stauffer 2004-05-12 12:26:12 UTC 
Created attachment 11521 [details]
Updated diff with white space changes removed
Comment 6 Elias Ross 2007-01-28 02:44:48 UTC 
Tested on my Oracle 9i.
Comment 7 Curt Arnold 2007-01-30 15:30:36 UTC 
Committed by Elias against log4j/trunk in rev 500776