Bug 22195 - [RFE] [PATCH] Support for Storage Class ID
Summary: [RFE] [PATCH] Support for Storage Class ID
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POIFS (show other bugs)
Version: 3.0-dev
Hardware: Other other
: P3 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
: 24183 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-08-07 04:01 UTC by Michael Zalewski
Modified: 2004-11-16 19:05 UTC (History)
1 user (show)


Attachments
diff and a new TestCase class (WinZip) (4.47 KB, application/octet-stream)
2003-08-07 04:04 UTC, Michael Zalewski 		Details
Diff and new TestCase against REL_2_BRANCH (5.39 KB, application/x-zip-compressed)
2003-08-09 00:06 UTC, Michael Zalewski 		Details
[PATCH] getters and setters for CLSID (3.43 KB, patch)
2003-10-31 21:18 UTC, Kirill Jacobson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Zalewski 2003-08-07 04:01:50 UTC 
Every node in a POIFS (OLE Structured File) has an associated 'storage Class 
ID', which is stored on the node from 0x50 - 0x5f. Also, 0x60 - 0x63 is 'User 
Flags'.

Provide an API to access the storage Class ID.

This may or may not be related to 
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20871

Excel 97 and above store the CLSID {00020820-0000-0000-C000-000000000046} at 
the root property. A new workbook created from HSSF does not store this. This 
patch does not change HSSF, but provides an API which HSSF might use to set 
this value.
Comment 1 Michael Zalewski 2003-08-07 04:04:05 UTC 
Created attachment 7682 [details]
diff and a new TestCase class (WinZip)
Comment 2 Andy Oliver 2003-08-07 04:14:52 UTC 
Can you provide a patch against the REL_2_BRANCH. . This should go in the release as its pretty 
serious.  (anyone disagree?)
Comment 3 Michael Zalewski 2003-08-07 04:23:12 UTC 
Hmmm. Might actually be against REL_2_BRANCH. I just pulled the default branch 
and made it this evening.

But it don't have to go into Release 2. It really has no effect on HSSF, or 
anything else. If it were me, I would wait for Release 3, unless someone uses 
it to fix an actual problem.

However, the new TestCase is against org.apache.poi.hpsf.ClassID, which 
formerly had no testcase.
Comment 4 Andy Oliver 2003-08-07 15:01:44 UTC 
yes the head is rel 3.  I'd like to use it for rel 2.
Comment 5 Michael Zalewski 2003-08-09 00:06:27 UTC 
Created attachment 7703 [details]
Diff and new TestCase against REL_2_BRANCH
Comment 6 Avik Sengupta 2003-10-30 18:34:28 UTC 
*** Bug 24183 has been marked as a duplicate of this bug. ***
Comment 7 Avik Sengupta 2003-10-30 18:37:51 UTC 
I told Kirill on the other bug that he was too late for 2.0. But this one has
been around for a while, and Andy mentioned he liked it for 2.0. What say folks,
should we add this to 2.0? Since there is a testcase, maybe we should?
Comment 8 Avik Sengupta 2003-10-31 16:56:20 UTC 
Comitted. both to Branch and HEAD. Please cross-check, ClassID.java from the
branch pathc didnt apply cleanly to HEAD, so I took that out of the HEAD patch
attached to this bug. All tests pass in branch. The relevant tests pass on HEAD. 

Kirill, if you can get the gettter/setter in by end of friday, it might still go
into the next release. Reopen this bug when you do. Thanks.
Comment 9 Kirill Jacobson 2003-10-31 21:18:39 UTC 
Created attachment 8860 [details]
[PATCH] getters and setters for CLSID
Comment 10 Kirill Jacobson 2003-10-31 21:20:10 UTC 
Reopened: Added a patch with CLSID getters and setters for DirectoryNode and 
DirectoryEntry
Comment 11 Avik Sengupta 2003-11-01 02:21:22 UTC 
Comitted. Thanks. Please cross check.