| Summary: | DataSourceRealm should provide more info on SQLException | ||
|---|---|---|---|
| Product: | Tomcat 7 | Reporter: | mkbucc |
| Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 7.0.34 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X 10.4 | ||
| Attachments: | Patch proposal | ||
Created attachment 29883 [details]
Patch proposal
+1
Information for SQLException can be provided for methods:
- getPassword(Connection, String)
- getRoles(Connection, String)
Thanks for the patch. It has been applied to trunk and 7.0.x and will be included in 7.0.36 onwards. |
The getPassword() method of the DataSourceRealm does not log enough information when it encounters an SQL error. The catch block is: } catch(SQLException e) { containerLog.error( sm.getString("dataSourceRealm.getPassword.exception", username)); } finally { it would be really helpful to have some details of what the SQLException is. I am getting this intermittently, and have resorted to subclassing getPassword() in an attempt to figure out what is going wrong.