Summary: | An incomplete fix for the resource leak bug in MemoryUserDatabase.java | ||
---|---|---|---|
Product: | Tomcat 7 | Reporter: | lianggt08 |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | critical | ||
Priority: | P2 | ||
Version: | trunk | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All |
Description
lianggt08
2012-02-21 11:50:36 UTC
revision 423920 has nothing to do with attempting to prevent a resource leak. The situation described in this report would generate an error message to the logs on start-up which is very likely to result in Tomcat being shut down and the issue fixed. Even if the issue is not fixed, it would result in a single fd leak. The component that this report references is not intended for production use. Taken together, the above mean that a severity of critical is not appropriate for this issue. It would do very little / no harm to leave the code as it is. This is really an enhancement request to clean up the code a little. This is the second issue of this nature I have reviewed from this reporter that has demonstrated a lack of understanding of the code concerned and over inflated the severity of the issue. It is becoming increasingly tempting to simply close all the issues from this reporter as INVALID until they demonstrate the ability to do some proper analysis. |