| Summary: | When OutputBuffer.doFlush gets Exception, doFlush gets stuck to true | ||
|---|---|---|---|
| Product: | Tomcat 7 | Reporter: | Bow Ruggeri <bow.ruggeri> |
| Component: | Connectors | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 7.0.14 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
The line that causes doFlush to be stuck at true if it gets an exception
Patch |
||
Created attachment 27122 [details]
Patch
I'm also experiencing this problem. Attached is a patch implementing both of Bow's suggestions. Thanks for the patch. This has been fixed in 7.0.x and will be included in 7.0.16 onwards. Proposed for backport to 6.0 and 5.5. Fixed in 6.0.x and included in 6.0.33 onwards |
Created attachment 27114 [details] The line that causes doFlush to be stuck at true if it gets an exception First time opening a bug, please forgive me if this report isn't perfect! I recently ran into an issue where OutputBuffer's doFlush gets stuck to true. In OutputBuffer.doFlush(boolean) it sets doFlush = true, then calls bb.flushBuffer, then sets doFlush = false. I issue I ran into was bb.flushBuffer eventually calls OutputBuffer.realWriteBytes. The realWriteBytes eventually calls coyoteResponse.doWrite. If coyoteResponse.doWrite throws an IOException, then it rethrows a ClientAbortException. What I am seeing is my client disconnecting early, and causing the doWrite to throw a SocketException of "Broken pipe". That broken pipe causes a ClientAbortException to be thrown. When that is thrown, the error is bubbled up and doFlush is stuck as "true". The next time the processor is used, it calls the recycle() method in OutputBuffer. However, the recycle doesn't reset doFlush so its still set to true. I imagine there are quite a few ways to fix this, but the two obvious ones that come to mind are: - Have recycle() set doFlush back to false or - Have throw a finally in try/catch/finally in OutputBuffer.doFlush so doFlush is set back to false when an Exception is catch