Summary: | NullPointerException when min-height is specified for table-row | ||
---|---|---|---|
Product: | Fop - Now in Jira | Reporter: | Isaac Shabtay <isaac> |
Component: | page-master/layout | Assignee: | fop-dev |
Status: | CLOSED FIXED | ||
Severity: | major | ||
Priority: | P2 | ||
Version: | trunk | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Isaac Shabtay
2007-10-10 13:36:32 UTC
Confirmed. I tested your FO on the latest code from Trunk and NPE still occurs there too :-( Right, but we also don't claim that min-height is implemented. See here: http://xmlgraphics.apache.org/fop/compliance.html#fo-property-min-height block-progression-dimension.minimum does the same thing and that works. Jeremias, I agree that min-height is declared to be unsupported on 0.94. Still, not supporting a feature does not make it "right" to abort on a runtime exception such as a NullPointerException. fo:table with table-layout="auto" is also not supported; however, using table-layout="auto" is handled correctly: A message is displayed saying that it is not supported, but processing *continues* while the unsupported attribute is ignored. I would expect the same kind of behavior (logging a message & ignoring the unsupported attribute) when using min-height. Hoping that my claim convinced anybody, I am re-setting severity to Major; NullPointerExceptions due to incomplete / unsupported code is an extremely bad practice IMO. I will attempt to create an Eclipse workspace using the Trunk version and submit a patch for it. Isaac (In reply to comment #3) > > Still, not supporting a feature does not make it "right" to abort on a runtime > exception such as a NullPointerException. <snip /> Agreed. I'll see if I can add a warning for this unimplemented property. Note that 'block-progression-dimension.minimum' is a valid alternative only in certain circumstances (depending on reference-orientation and writing-mode). 'b-p-d' is not always the same as 'height'. If it were that simple, we'd probably have implemented it already... On the same note: since the issue still exists in FOP Trunk, and it is probably safe to say that it can be reproduced on all platforms, I have changed those bug-properties as well. Bug has been fixed in FOP Trunk, but only now I discovered this related entry. The min-height/max-height and min-width/max-width properties have (finally) been activated. see: http://svn.apache.org/viewvc?rev=652456&view=rev batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed |