Bug 39437

Summary:	NTEventLogAppender uses code from JNI Prog Manual
Product:	Log4j - Now in Jira	Reporter:	Curt Arnold <carnold>
Component:	Appender	Assignee:	log4j-dev <log4j-dev>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P2
Version:	1.3alpha
Target Milestone:	---
Hardware:	Other
OS:	other

Description Curt Arnold 2006-04-27 22:59:31 UTC

Discussed on log4j-dev on 19 Mar 2006
(http://marc.theaimsgroup.com/?l=log4j-dev&m=114274873223429&w=2).

Janet Campbell of Eclipse Foundation Inc. expressed concerns that
src/java/org/apache/log4j/nt/nteventlog.cpp contained about 60 lines of code
that  was copied  from "The Java Native Interface: Programmer's Guide and
Specification"  (http://java.sun.com/docs/books/jni).  The code was used to
perform an unnecessary conversion of Java strings to the local code page. 
nteventlog.cpp in the trunk has been modified to avoid the unnecessary
conversion and no longer contains the code of concern.

Comment 1 Curt Arnold 2006-04-27 23:00:48 UTC

Committed rev 397672.