Summary: | SSL_ variables from mod_ssl not available for RewriteCond tests in mod_rewrite | ||
---|---|---|---|
Product: | Apache httpd-2 | Reporter: | Rüdiger Plüm <ruediger.pluem> |
Component: | mod_rewrite | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
Status: | CLOSED FIXED | ||
Severity: | normal | Keywords: | PatchAvailable |
Priority: | P3 | ||
Version: | 2.0.50 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Solution proposal patch
Documentation patch |
Description
Rüdiger Plüm
2004-08-04 13:08:13 UTC
Created attachment 12327 [details]
Solution proposal patch
Currently my patch is missing the according patch of the mod_rewrite documentation. As my patch is a backport (even from the coding point of view as I compared my patch and an actual CVS snapshot of Apache 2.1) of the same functionality offered by Apache 2.1 I simply backported the according paragraph for the Apache 2.1 documentation of mod_rewrite.xml. So the contents of the documentation patch I will attach has been written by one of the Apache 2.1 mod_rewrite contributors / authors. Created attachment 12515 [details]
Documentation patch
Thanks for the patch. This has been proposed for backport to 2.0. It can't be done by including mod_ssl.h, since that fails if mod_ssl is not enabled in 2.0, so the optional function declarations have to be duplicated. For references, the proposed patches are: http://www.apache.org/~jorton/mod_rewrite-2.0-sslvar.diff http://www.apache.org/~jorton/mod_ssl-2.0-ishttps.diff Thanks for the feedback and the references. You are right it is not possible to include mod_ssl.h in Apache 2.0 without enabling it via configure. I did not notice that as I compile my Apache always with mod_ssl. So I included mod_ssl.h to avoid the duplication of the optional function declarations. It is nice to hear that this feature should be backported to Apache 2.0. Do you already know a release of Apache 2.0 in which this will be included? The backport requires votes from two additional developers, so it depends when people have time to review the changes. Now committed for 2.0.51. Thats very good news. Thanks. |