Allow ServiceMix 3 to build using the ibm jdk.

• Key: SM-1442
• Type: Task
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Guillaume Nodet
• Reporter: Peter Jones
• Component/s: servicemix-core, servicemix-components, servicemix-http, servicemix-jsr181, servicemix-jbi, tooling, servicemix-eip, servicemix-cxf-bc
• Fix Version/s: 3.3, 3.2.3

Description

Made some changes needed to resolve some build and test failures when using the ibm jdk.

I've attached patches for the 3.2 branch and smx3 trunk to fix some issues when building with the ibm jdk (changes also tested with the sun jdk). The changes include adding a profile for the ibmjdk to skip checkstyle for a few files which have non-ascii characters (causes build problems for the ibm jdk). Also, made a couple of minor changes to get a couple of tests to use dynamic ports to lessen the likelihood of port conflicts. Changed a couple of usages of sun specific classes.

Comments

[Peter Jones]

Any comments or suggestions for improvements, please let me know!

[Lars Heinemann]

Peter,

we would like to test your changes on the SMX3 trunk version. Maybe you could adapt your patch to
the trunk version?

Regards
Lars

[Peter Jones]

Hi Lars,

For sure, I'm working on putting together a similar patch for smx3 trunk and the components and I'll attach it here once its complete.

Cheers,
Peter

[Peter Jones]

Patch for smx3-trunk.

[Peter Jones]

Patch for component shared-libraries.

[Peter Jones]

Patch for service engine eip.

[Peter Jones]

Patch for service engine jsr181.

[Peter Jones]

Patch for service engine wsn2005.

[Peter Jones]

Patch for http binding component.

[Peter Jones]

Reattach patch for branch 3.2. Looks like I must have omitted checking the grant asf license button first time. Checked this time.

[Peter Jones]

Missed attaching this patch.

[Peter Jones]

Updated patch for changes since patch was first attached to issue.

[Peter Jones]

Updated patch for changes that were committed since patch was uploaded.

[Peter Jones]

Hi there,

Updated a couple of the patches to keep up with changes. If there are any comments or suggestions for improvements, please let me know.

Cheers,
Peter

[Peter Jones]

Updated description and effected components.

[Lars Heinemann]

Peter,

thanks for your hard work
Hopefully I will be able to test your patches within the next week.

Regards
Lars

[Peter Jones]

Hi there,

Thanks very much for applying the patches! I had one question though... I added a property file in the cxf binding component patch and the 3.2 branch patch. It configured the security provider list when using the ibm jdk to work around a couple of security test failures. It looks like the file was omitted from being added when the patch was applied though. Was this just an svn hiccup since the property file was the only file added by the patches rather than being modified? Or was it left out for some reason? I notice the configuration to pick up the property file is still in the cxf binding component pom.xml, so I'm guessing it may have been omitted by accident.

Cheers,
Peter

The file src/test/resources/ibm.security looked like this by the way:

#
#    Licensed to the Apache Software Foundation (ASF) under one or more
#    contributor license agreements.  See the NOTICE file distributed with
#    this work for additional information regarding copyright ownership.
#    The ASF licenses this file to You under the Apache License, Version 2.0
#    (the "License"); you may not use this file except in compliance with
#    the License.  You may obtain a copy of the License at
#
#       http://www.apache.org/licenses/LICENSE-2.0
#
#    Unless required by applicable law or agreed to in writing, software
#    distributed under the License is distributed on an "AS IS" BASIS,
#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#    See the License for the specific language governing permissions and
#    limitations under the License.
#
# On the ibm jdk, we want to place IBMJCE before IBMJSSEProvider2 in the
# list of providers when running a couple of security tests to prevent
# them from failing.
#
security.provider.1=com.ibm.crypto.provider.IBMJCE
security.provider.2=com.ibm.jsse2.IBMJSSEProvider2

[Freeman Fang]

add missing file ibm.security both for trunk and 3.2 branch
http://svn.apache.org/viewvc?rev=686945&view=rev
http://svn.apache.org/viewvc?rev=686946&view=rev