createConnector="false" has no effect on Tiger

• Key: AMQ-950
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Unassigned
• Reporter: Renaud Bruyeron
• Component/s: Broker
• Affects Version/s: 4.1.0
• Fix Version/s: 4.1.0

Description

On Tiger, activemq always creates a rmi connector on port 1099 no matter what I do with -Djavax.management... and <managementContext/>
In particular, setting createConnector="false" should prevent AMQ from setting up its own connector, but it does not.

The problem is in the findMBeanServer() method:
if (result == null && createMBeanServer) { result = createMBeanServer(); }
else { createConnector(result); }

result is not null on Tiger with useJmx="true", and createConnector is not protected by if(createConnector) like it is on the non-Tiger flow.
The fix (I think) is simply to do this:
if (result == null && createMBeanServer) { result = createMBeanServer(); } }
else {
if(createConnector){ createConnector(result); }
}

Comments

[James Strachan]

Patch applied - many thanks Renaud.

BTW could you double check my version of your patch works - I only create a connector if result != null and createConnector is true.

[Renaud Bruyeron]

Hi James,

this looks correct to me, however I can't play with the latest 4.1 snapshots because they break with servicemix-3.0 final
(something wrong with jencks and the RA). It broke in the last 3 weeks (snapshot from 20060830 works).

[Renaud Bruyeron]

me again,

sorry, I meant to say that I plan to look into this issue with the latest snapshots - I don't have time right now but it is on my todo to provide more info on the problem I am seeing