ActiveMQActivationSpec does not validate that DestinationType is set to Topic when SubscriptionDurability is set to Durable

• Key: AMQ-705
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Hiram Chirino
• Reporter: John Sisson
• Component/s: JCA Container
• Affects Version/s: 3.2.1, 3.2.2, 4.0 M4, 3.2.3, 4.0 RC2, 4.0 RC3
• Fix Version/s: 4.0, 3.2.4

Description

Found problem when using Geronimo with an incorrectly configured EJB 2.0 MDB that has:

<message-driven-destination>
<destination-type>javax.jms.Queue</destination-type>
<subscription-durability>Durable</subscription-durability>
</message-driven-destination>

The above config doesn't make sense since subscription-durability is only applicable for Topics.

This resulted in a message that didn't directly point to the problem:

C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear myplan.xml
Error: Unable to distribute my.ear: JMS settings for
message-driven bean FooMDBean are not valid:
Invalid settings: clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

With the patch applied, the error will now be:

C:\test>java -jar geronimo-1.1-SNAPSHOT\bin\deployer.jar --user system --password manager deploy my.ear wmyplan.xml
Error: Unable to distribute my.ear: JMS settings for
message-driven bean FooMDBean are not valid:
Invalid settings: subscriptionDurability cannot be set to: Durable when destinationType is set to javax.jms.Queue as it is only valid when destinationType is set to javax.jms.Topic. clientId must be set since durable subscription was requested. subscriptionName must be set since durable subscription was requested.

Comments

[John Sisson]

Attached patch for review for activemq-3 branch.

[John Sisson]

Attached patch for review for incubator trunk.

[Hiram Chirino]

Great patch! Applied!