Add PropertyPlaceholderConfigurer to default activemq.xml

• Key: AMQ-699
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Hiram Chirino
• Reporter: Jason Dillon
• Component/s: Broker
• Affects Version/s: 4.0 M4, 4.0 RC2, 4.0 RC3
• Fix Version/s: 4.1.0, 4.0.1

Description

The default activemq.xml should include a Spring PropertyPlaceholderConfigurer to allow the activemq.home property to be used to root directories.

For example, this configuration will save data to ${activemq.home}/var/data always, no matter where the script was run from.

<beans xmlns="http://activemq.org/config/1.0">

    <bean class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
        <property name="systemPropertiesModeName" value="SYSTEM_PROPERTIES_MODE_OVERRIDE"/>
    </bean>

    <broker useJmx="true">
        <persistenceAdapter>
            <journaledJDBC journalLogFiles="5" dataDirectory="${activemq.home}/var/data"/>
        </persistenceAdapter>
    
        <transportConnectors>
            <transportConnector name="default" uri="tcp://localhost:16161" discoveryUri="multicast://default"/>
        </transportConnectors>

    </broker>
</beans>

Also, the default Log4j configuration should be augmented to use this property for the out appender:

# File appender
log4j.appender.out=org.apache.log4j.RollingFileAppender
log4j.appender.out.file=${activemq.home}/var/log/activemq.log
log4j.appender.out.maxFileSize=1024KB
log4j.appender.out.maxBackupIndex=5
log4j.appender.out.append=true
log4j.appender.out.layout=org.apache.log4j.PatternLayout
log4j.appender.out.layout.ConversionPattern=%d [%-15.15t] %-5p %-30.30c{1} - %m%n

Comments

[Hiram Chirino]

fix details due to wiki renderer switch.

[Hiram Chirino]

Commited this change to 4.1 and 4.01 code branches. Thanks for the Idea jason!