[#AMQ-1858] Integer overflow in default settings - Apache ActiveMQ & Apache ServiceMix

ActiveMQ

Integer overflow in default settings

Created: 17/Jul/08 08:09 AM Updated: 14/Aug/08 02:33 AM

Component/s:

Broker

Affects Version/s:

5.1.0

Fix Version/s:

5.2.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Attached Date	Attached By	Size
	amq_1858.patch	2008-07-24 12:13 PM	Earl Woodman	2 kb

Description

« Hide

From BrokerService, line 711-2:

systemUsage.getTempUsage().setLimit(1024 * 1024 * 1024 * 100); // 10 Gb
systemUsage.getStoreUsage().setLimit(1024 * 1024 * 1024 * 100); // 100 GB

The expression 1024 * 1024 * 1024 * 100 overflows int, so the above lines actually correspond to setLimit(0).
Easy fix is to make one of the multipliers a long, for example:

1024L * 1024 * 1024 * 100

Other places may have the same problem, but I did not look for all places.

All

Comments

Work Log

Change History

Subversion Commits

FishEye

Crucible

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Earl Woodman - 24/Jul/08 12:13 PM

Attaching a patch which fixes this issue and adds a unit test to ensure its correctness in the future.

[ Permlink | « Hide ]

Rob Davies - 14/Aug/08 02:33 AM

Fixed applied in SVN revision 685832