PooledConnectionFactory not JNDI refereceable

• Key: AMQ-1614
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Trivial
• Assignee: Rob Davies
• Reporter: Linus Larsen
• Component/s: JMS client
• Affects Version/s: 5.0.0
• Fix Version/s: 5.3.0

Description

The PooledConnectionFactory does not extend JNDIBaseStorable neither implements JNDIStorableInterface which makes it impossible to store it in a JNDI tree. It is not a problem when using Spring, but when using for example Tomcat and context.xml as configuration it simply does not work.

Attaching a simple fix on how this can be resolved.

Comments

[Hiram Chirino]

Hi Linus,

I would love to add this patch to the ActiveMQ distribution but I can't unless you submit the patch with the Apache copyright headers and you click the check box saying you grant the ASF a license to this code when you submit the patch. Please resubmit so I can get this included in the 5.1.0 release.

[Linus Larsen]

Sure thing, i think it would work now. Let me know otherwise

[Rob Davies]

Patch applied in SVN revision 692178

[Krunal Shimpi]

The fix provided in patch is not 100% complete.

PooledConnectionFactory provides following 3 constructors:
1. PooledConnectionFactory()
2. PooledConnectionFactory(ActiveMQConnectionFactory connectionFactory)
3. PooledConnectionFactory(String brokerURL)

The New class AmqJNDIPooledConnectionFactory fixes JNDI problem but though this class extends PooledConnectionFactory, it is provided with support for zero argument constructor.

Can you please provide all 3 constructors for AmqJNDIPooledConnectionFactory class and release patch again?

[Rob Davies]

Fixed by SVN revision 799530