Username and password field got swapped when calling PooledConnection.createConnection

• Key: AMQ-1365
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: William Lam
• Component/s: JMS client
• Affects Version/s: 4.1.1
• Fix Version/s: 4.1.2, 5.1.0

Description

When using org.apache.activemq.pool.PooledConnection createConnection(username, password), the username and password fields are swapped.

I think the problem could be the following, based in 4.1.1 source code,

PooledConnection.java line 77

public synchronized Connection createConnection(String userName, String password) throws JMSException {
ConnectionKey key = new ConnectionKey(userName, password);

ConnectionKey.java line 30

public ConnectionKey(String password, String userName) {
this.password = password;
this.userName = userName;

Comments

Thanks!

Updated the 4.1 branch and trunk to address this issue :

4.1 branch : rev 568868
trunk : rev 568869