Issue Details (XML | Word | Printable)

Key: AMQ-1293
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Rob Davies
Reporter: Albert Strasheim
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
ActiveMQ

Fix FindBugs issues

Created: 23/Jun/07 10:33 AM   Updated: 25/Jun/07 05:55 AM
Return to search
Component/s: None
Affects Version/s: 5.0.0
Fix Version/s: 5.0.0

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
Text File findbugs0.patch 2007-06-23 10:33 AM Albert Strasheim 147 kB

Patch Info: Patch Available


 Description  « Hide
FindBugs 1.2.1 find various issues in the ActiveMQ code that look like they need some attention. While we sort out FindBugs in the Maven build, using the Eclipse plugin for FindBugs is a quick way to get going:

http://findbugs.sourceforge.net/downloads.html

I'm attaching a first patch that addresses some basic issues.

The other major the FindBugs points out is "inconsistent synchronization" in various cursor and Kaha and other org.apache.activemq.store classes.

 All   Comments   Work Log   Change History   Subversion Commits   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
James Strachan added a comment - 25/Jun/07 12:46 AM
Fancy taking a stab at this one?

James Strachan made changes - 25/Jun/07 12:46 AM
Field Original Value New Value
Assignee Hiram Chirino [ chirino ]
Rob Davies made changes - 25/Jun/07 02:42 AM
Assignee Hiram Chirino [ chirino ] Rob Davies [ rajdavies ]
[ Permlink | « Hide ]
Rob Davies added a comment - 25/Jun/07 02:42 AM
this will take some effort to ensure we really are fixing stuff

550449 by  Rob Davies (71 files)
25/Jun/07 03:45 AM (28 months, 17 days ago)
Applying patch from http://issues.apache.org/activemq/browse/AMQ-1293
trunk/activemq-core/src/test/java/org/apache/activemq/JMSConsumerTest.java 550449 history download (+65 -65) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/transport/TopicClusterTest.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQStreamMessage.java 550449 history download (+5 -5) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQMapMessage.java 550449 history download (+5 -5) diffs
trunk/activemq-core/src/test/eclipse-resources/log4j.properties 550449 history download (+10 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/security/LDAPAuthorizationMapTest.java 550449 history download (+0 -1) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/util/TypeConversionSupport.java 550449 history download (+4 -4) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/data/DataManagerImpl.java 550449 history download (+3 -3) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/proxy/ProxyConnectorTest.java 550449 history download (+3 -3) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/async/AsyncDataManager.java 550449 history download (+6 -6) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/bugs/JmsDurableTopicSlowReceiveTest.java 550449 history download (+3 -3) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/transport/reliable/DefaultReplayBuffer.java 550449 history download (+3 -3) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/store/kahadaptor/KahaTopicReferenceStore.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/openwire/v3/BaseDataStreamMarshaller.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/AMQDeadlockTest3.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/broker/StubBroker.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/transport/failover/FailoverTransportBrokerTest.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQMessage.java 550449 history download (+5 -6) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/openwire/v1/ActiveMQTextMessageTest.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/JMSUsecaseTest.java 550449 history download (+16 -16) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/filter/UnaryExpression.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/async/DataFileAppender.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/transport/tcp/InactivityMonitorTest.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/LargeStreamletTest.java 550449 history download (+2 -2) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/broker/MessageExpirationTest.java 550449 history download (+24 -24) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/util/MarshallingSupport.java 550449 history download (+7 -5) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/broker/BrokerTest.java 550449 history download (+114 -114) diffs
trunk/activemq-core/src/test/java/org/apache/activemq/broker/BrokerTestSupport.java 550449 history download (+1 -1) diffs
trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/ProtocolConverter.java 550449 history download (+2 -2) diffs
...41 more files in changeset

Repository Revision Date User Message
AMQ #550449 Mon Jun 25 03:45:55 PDT 2007 rajdavies Applying patch from http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JMSConsumerTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/TopicClusterTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQStreamMessage.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQMapMessage.java
MODIFY /activemq/trunk/activemq-core/src/test/eclipse-resources/log4j.properties
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/security/LDAPAuthorizationMapTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/util/TypeConversionSupport.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/data/DataManagerImpl.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/proxy/ProxyConnectorTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/async/AsyncDataManager.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/bugs/JmsDurableTopicSlowReceiveTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/reliable/DefaultReplayBuffer.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/kahadaptor/KahaTopicReferenceStore.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/v3/BaseDataStreamMarshaller.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/AMQDeadlockTest3.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/broker/StubBroker.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/failover/FailoverTransportBrokerTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/command/ActiveMQMessage.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/LDAPAuthorizationMap.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/openwire/v1/ActiveMQTextMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JMSUsecaseTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/filter/UnaryExpression.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/async/DataFileAppender.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/tcp/InactivityMonitorTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/LargeStreamletTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/broker/MessageExpirationTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/util/MarshallingSupport.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/broker/BrokerTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/broker/BrokerTestSupport.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/ProtocolConverter.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/openwire/v1/BrokerInfoTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/LoadTestBurnIn.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/fanout/FanoutTransportBrokerTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/kahadaptor/TopicSubContainer.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/test/message/NestedMapMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/openwire/v1/MessageAckTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/ManagementContext.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/jmx/OpenTypeSupport.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/filter/ComparisonExpression.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/test/retroactive/DummyMessageQuery.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/perf/AMQStoreQueueTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/usecases/ChangeSentMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/thread/Scheduler.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/network/SimpleNetworkTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/filter/ConstantExpression.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/util/MemoryPropertyEditor.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/ResponseCorrelator.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JMSExclusiveConsumerTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/AuthorizationEntry.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/openwire/v2/BaseDataStreamMarshaller.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JMSMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/tcp/TcpTransportServer.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/broker/virtual/CompositeQueueTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/usecases/AMQFailoverIssue.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/tcp/SslTransportTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/kahadaptor/KahaReferenceStoreAdapter.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/JmsTransactionTestSupport.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/DurableTopicSubscription.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/command/ActiveMQBytesMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/command/ActiveMQStreamMessageTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/usecases/AMQDeadlockTestW4Brokers.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/usecases/TopicRedeliverTest.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/transport/peer/PeerTransportTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/transport/stomp/StompWireFormat.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/PropertiesBrokerFactory.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/network/ForwardingBridge.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/kaha/impl/index/IndexManager.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/filter/PropertyExpression.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/security/SimpleSecurityBrokerSystemTest.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/util/MemoryIntPropertyEditor.java
MODIFY /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/perf/SimpleTopicTest.java

550450 by  Rob Davies (4 files)
25/Jun/07 03:55 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550450 Mon Jun 25 03:55:11 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-console/src/main/java/org/apache/activemq/console/command/ShutdownCommand.java
MODIFY /activemq/trunk/activemq-console/src/main/java/org/apache/activemq/console/filter/WildcardToMsgSelectorTransformFilter.java
MODIFY /activemq/trunk/activemq-console/src/main/java/org/apache/activemq/console/filter/WildcardToRegExTransformFilter.java
MODIFY /activemq/trunk/activemq-console/src/main/java/org/apache/activemq/console/util/JmxMBeansUtil.java

550451 by  Rob Davies (4 files)
25/Jun/07 03:57 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550451 Mon Jun 25 03:57:57 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-jaas/src/main/java/org/apache/activemq/jaas/LDAPLoginModule.java
MODIFY /activemq/trunk/activemq-jaas/src/main/java/org/apache/activemq/jaas/TextFileCertificateLoginModule.java
MODIFY /activemq/trunk/activemq-jaas/src/test/java/org/apache/activemq/jaas/CertificateLoginModuleTest.java
MODIFY /activemq/trunk/activemq-jaas/src/main/java/org/apache/activemq/jaas/PropertiesLoginModule.java

550454 by  Rob Davies (4 files)
25/Jun/07 04:25 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550454 Mon Jun 25 04:25:21 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-openwire-generator/src/main/java/org/apache/activemq/openwire/tool/CHeadersGenerator.java
MODIFY /activemq/trunk/activemq-openwire-generator/src/main/java/org/apache/activemq/openwire/tool/SingleSourceGenerator.java
MODIFY /activemq/trunk/activemq-openwire-generator/src/main/java/org/apache/activemq/openwire/tool/MultiSourceGenerator.java
MODIFY /activemq/trunk/activemq-openwire-generator/src/main/java/org/apache/activemq/openwire/tool/JavaTestsGenerator.java

550472 by  Rob Davies (5 files)
25/Jun/07 05:40 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550472 Mon Jun 25 05:40:25 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-ra/src/test/java/org/apache/activemq/ra/MessageEndpointProxyTest.java
MODIFY /activemq/trunk/activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQActivationSpec.java
MODIFY /activemq/trunk/activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQEndpointActivationKey.java
MODIFY /activemq/trunk/activemq-ra/src/test/java/org/apache/activemq/ra/MDBTest.java
MODIFY /activemq/trunk/activemq-ra/src/main/java/org/apache/activemq/ra/ActiveMQConnectionRequestInfo.java

550473 by  Rob Davies (2 files)
25/Jun/07 05:46 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550473 Mon Jun 25 05:46:26 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/activemq-web/src/main/java/org/apache/activemq/web/MessageServlet.java
MODIFY /activemq/trunk/activemq-web/src/main/java/org/apache/activemq/web/PortfolioPublishServlet.java

550476 by  Rob Davies (2 files)
25/Jun/07 05:49 AM (28 months, 17 days ago)
Repository Revision Date User Message
AMQ #550476 Mon Jun 25 05:49:00 PDT 2007 rajdavies apply patch http://issues.apache.org/activemq/browse/AMQ-1293
Files Changed
MODIFY /activemq/trunk/assembly/src/test/java/org/apache/activemq/benchmark/Producer.java
MODIFY /activemq/trunk/assembly/src/test/java/org/apache/activemq/benchmark/BenchmarkSupport.java

[ Permlink | « Hide ]
Rob Davies added a comment - 25/Jun/07 05:55 AM
Applied to trunk - revision 550476

Rob Davies made changes - 25/Jun/07 05:55 AM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Create crucible review for all 7 changesets in

Powered by a free Atlassian JIRA open source license for Apache Software Foundation - ActiveMQ. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators