[#AMQ-1293] Fix FindBugs issues - Apache ActiveMQ & Apache ServiceMix

ActiveMQ

Fix FindBugs issues

Created: 23/Jun/07 10:33 AM Updated: 25/Jun/07 05:55 AM

Component/s:

None

Affects Version/s:

5.0.0

Fix Version/s:

5.0.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Attached Date	Attached By	Size
	findbugs0.patch	2007-06-23 10:33 AM	Albert Strasheim	147 kb

Patch Info:

Patch Available

Description

« Hide

FindBugs 1.2.1 find various issues in the ActiveMQ code that look like they need some attention. While we sort out FindBugs in the Maven build, using the Eclipse plugin for FindBugs is a quick way to get going:

http://findbugs.sourceforge.net/downloads.html

I'm attaching a first patch that addresses some basic issues.

The other major the FindBugs points out is "inconsistent synchronization" in various cursor and Kaha and other org.apache.activemq.store classes.

All

Comments

Work Log

Change History

Subversion Commits

FishEye

Crucible

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

James Strachan - 25/Jun/07 12:46 AM

Fancy taking a stab at this one?

[ Permlink | « Hide ]

Rob Davies - 25/Jun/07 02:42 AM

this will take some effort to ensure we really are fixing stuff

[ Permlink | « Hide ]

Rob Davies - 25/Jun/07 05:55 AM

Applied to trunk - revision 550476