Allow activeio 3.1-SNAPSHOT to be compiled with JDK 1.4

• Key: AMQ-1184
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Jason Dillon
• Fix Version/s: 4.1.1

Description

Use of one new-style for loop in activeio (and pom.xml config) is preventing activeio 3.1-SNAPSHOT from being used on JDK 1.4...

Comments

[James Strachan]

Patch applied with thanks - fingers crossed the nightly build will kick in soon...

Well... AIO is happy now... but looks like more Java 5 stuff is in the AMQ 4.1 snapshot:

java.lang.NoClassDefFoundError: java/util/concurrent/ExecutionException
        at org.apache.activemq.store.DefaultPersistenceAdapterFactory.createJournal(DefaultPersistenceAdapterFactory.java:224)
        at org.apache.activemq.store.DefaultPersistenceAdapterFactory.getJournal(DefaultPersistenceAdapterFactory.java:132)
        at org.apache.activemq.store.DefaultPersistenceAdapterFactory.createPersistenceAdapter(DefaultPersistenceAdapterFactory.java:70)
        at org.apache.activemq.broker.BrokerService.createPersistenceAdapter(BrokerService.java:1320)
        at org.apache.activemq.broker.BrokerService.getPersistenceAdapter(BrokerService.java:631)
        at org.apache.activemq.broker.BrokerService.createRegionBroker(BrokerService.java:1250)
        at org.apache.activemq.broker.BrokerService.createBroker(BrokerService.java:1209)
        at org.apache.activemq.broker.BrokerService.getBroker(BrokerService.java:508)
        at org.apache.activemq.broker.BrokerService.start(BrokerService.java:394)
        at org.apache.activemq.gbean.BrokerServiceGBeanImpl.doStart(BrokerServiceGBeanImpl.java:94)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.createInstance(GBeanInstance.java:984)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.attemptFullStart(GBeanInstanceState.java:267)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.start(GBeanInstanceState.java:102)
        at org.apache.geronimo.gbean.runtime.GBeanInstanceState.startRecursive(GBeanInstanceState.java:124)
        at org.apache.geronimo.gbean.runtime.GBeanInstance.startRecursive(GBeanInstance.java:543)
        at org.apache.geronimo.kernel.basic.BasicKernel.startRecursiveGBean(BasicKernel.java:379)
        at org.apache.geronimo.kernel.config.ConfigurationUtil.startConfigurationGBeans(ConfigurationUtil.java:378)
        at org.apache.geronimo.kernel.config.KernelConfigurationManager.start(KernelConfigurationManager.java:187)
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:527)
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager.startConfiguration(SimpleConfigurationManager.java:508)
        at org.apache.geronimo.kernel.config.SimpleConfigurationManager$$FastClassByCGLIB$$ce77a924.invoke(<generated>)
        at net.sf.cglib.reflect.FastMethod.invoke(FastMethod.java:53)
        ...

[Jason Dillon]

So... even though the build is fine, and generating JDK 1.4 compatible classes... this codebase is still importing JDK 1.5 stuff, so its not buildable with JDK 1.4... nor is it usable by JDK 1.4.

May need to retrotranslate activeio so that activemq 4.1 can use it... see AMQ-1185

[James Strachan]

We'll leave 3.1 trunk of activeio against Java 5 in case we need it for ActiveMQ 5.x (which is based on Java 5), so we'll move ActiveMQ 4.1 branch back to 3.0.0 of activeio to keep it on Java 1.4

[Jason Dillon]

If that works... great!