Issue Details (XML | Word | Printable)

Key: AMQ-1181
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Hiram Chirino
Reporter: Hiram Chirino
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
ActiveMQ

Avoid Network Deadlocks if possible

Created: 26/Feb/07 11:43 AM   Updated: 05/Mar/07 08:26 AM
Return to search
Component/s: None
Affects Version/s: 4.0, 4.0.1
Fix Version/s: 4.1.1, 5.0.0

Time Tracking:
Not Specified


 Description  « Hide
When you depend on the brokers to flow control your producers, the brokers are usually running with usage managers at 100%. Now if use this in network of brokers configuration it is very easy to get into a scenario where the brokers network bridges lock messages to send to the next broker but bock on the send and thus create a network deadlock.

 All   Comments   Work Log   Change History   Subversion Commits   FishEye   Crucible      Sort Order: Ascending order - Click to sort in descending order
Hiram Chirino added a comment - 26/Feb/07 11:56 AM
Several changes went into the 4.1 branch to help avoid these network deadlocks:

http://svn.apache.org/viewvc?view=rev&rev=511085 - enabled flow control again on network producers, but now use the sync acking on queues to avoid blocking the network connection. Takes advantage of the fix to AMQ-1123 solve deadlocks at the network bridge.
http://svn.apache.org/viewvc?view=rev&rev=511080 - disabled flow control on network producers


Hiram Chirino added a comment - 26/Feb/07 11:57 AM
Need to port the above changes to trunk.

Repository Revision Date User Message
AMQ #514720 Mon Mar 05 08:26:08 PST 2007 jlim ported fix to trunk :
http://issues.apache.org/activemq/browse/AMQ-1181
Files Changed
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/TransportConnection.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Queue.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/region/Topic.java
MODIFY /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/broker/ConnectionContext.java

Jonas Lim added a comment - 05/Mar/07 08:26 AM
ported to trunk : r514720

Jonas Lim made changes - 05/Mar/07 08:26 AM
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Create crucible review for this changeset in