RegionBroker resets JMS Timestamp

• Key: AMQ-1165
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Hiram Chirino
• Reporter: Dain Sundstrom
• Affects Version/s: 4.1.0
• Fix Version/s: 4.1.1, 5.0.0

Description

The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.

if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) { //timestamp not been disabled and has not passed through a network message.setTimestamp(System.currentTimeMillis()); }

Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.

Comments

[Jason Dillon]

Has anyone had a chance to look at this? This is a blocking issue for release of Geronimo 1.2 due to TCK certification...

[Hiram Chirino]

That logic was put in place as a "Feature".. In rev 511463 in 4.1 trunk I have now made that "Feature" optional so that we don't break JMS compliance.

also fixed in trunk rev 511464

[Dain Sundstrom]

I think you forgot to commit the test case.

[Hiram Chirino]

Your right.. corrected in rev 512102 and 512104